add parallel binary edge list shuffler script #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaAtulTewari
approved these changes
Apr 22, 2024
AdityaAtulTewari
requested changes
Apr 22, 2024
Comment on lines
+101
to
+102
| // spawn a goroutine for every page, since each page can fault | ||
| // todo (meyer): should we limit the number of concurrent goroutines? |
There was a problem hiding this comment.
Not todo, yes. make it a input parameter, also make threads controllable by a input parameter.
There was a problem hiding this comment.
threads is already controllable.
| var wg sync.WaitGroup | ||
| // spawn a goroutine for every page, since each page can fault | ||
| // todo (meyer): should we limit the number of concurrent goroutines? | ||
| for i := uint64(0); i < num_edges; i += uint64(pageSize / 16) { |
There was a problem hiding this comment.
This needs to also be a program input.
|
please revert the approval was a mistake |
meyerzinn
added a commit
that referenced
this pull request
Apr 22, 2024
This reverts commit e4c0ac3.
meyerzinn
added a commit
that referenced
this pull request
Apr 22, 2024
This reverts commit 82afae6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test this script with an edge list file:
I also checked that the triangle count did not change on rmat14 vs lonestar triangle counting, which isn't conclusive proof that the edge list is the same but is pretty strong evidence.