Accessibility: rewrite tags badges semantically in profile header

to fix the 'Write lists or groups of links semantically' issue reported by silktide.
utdal · Mar 13, 2024 · ef093b4 · ef093b4
1 parent 7712fb6
commit ef093b4
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 4 deletions.
diff --git a/public/css/app.css b/public/css/app.css
diff --git a/public/mix-manifest.json b/public/mix-manifest.json
@@ -1,6 +1,6 @@
 {
     "/js/app.js": "/js/app.js?id=ea6bbec3ef43683fe4b33708fb0b651f",
     "/js/manifest.js": "/js/manifest.js?id=dc9ead3d7857b522d7de22d75063453c",
-    "/css/app.css": "/css/app.css?id=cad69eef68bd3363be178962528faa9e",
+    "/css/app.css": "/css/app.css?id=6e7d6166f46f41af71523d7f72f9a1f5",
     "/js/vendor.js": "/js/vendor.js?id=ff8caa3d91b2371810b378ee6ef53038"
 }
diff --git a/resources/assets/sass/_profile.scss b/resources/assets/sass/_profile.scss
@@ -16,6 +16,17 @@
 			font-size: 1.05rem;
 			margin-top: 1.7rem;
 		}
+
+		.tags {
+			ul {
+				display: inline;
+				padding-inline-start: 0px;
+			}
+
+			li {
+				display: inline;
+			}
+		}
 	}
 
 	.profile_photo {

diff --git a/resources/views/tags/badge.blade.php b/resources/views/tags/badge.blade.php
@@ -1,3 +1,5 @@
-@foreach($tags as $tag)
-<a class="badge badge-primary tags-badge" href="{{ route('profiles.index', ['search' => $tag->name]) }}">{{ $tag->name }}</a>
-@endforeach
+<ul>
+    @foreach($tags as $tag)
+        <li><a class="badge badge-primary tags-badge" href="{{ route('profiles.index', ['search' => $tag->name]) }}">{{ $tag->name }}</a></li>
+    @endforeach
+</ul>