Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds student research form validations #166

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Adds student research form validations #166

wants to merge 4 commits into from

Conversation

betsyecastro
Copy link
Contributor

@betsyecastro betsyecastro commented Oct 8, 2024 •
edited
Loading

Among other backend validations, this PR includes:

  • To address a IDOR vulnerability reported where the request can be intersected to include private profiles in the faculty members selection, this PR includes the validation to check that the profiles selected are public.
  • Check presence of semester availability for the selected semesters.
  • Check presence of language proficiency levels for the selected languages.
  • Check presence of the answers to the school custom questions based on the school selection made.

@betsyecastro betsyecastro added ✨ enhancement New feature or request ⚡️ performance Related to performance or efficiency 🔒 security Security-related labels Oct 8, 2024
@betsyecastro betsyecastro requested a review from wunc October 8, 2024 19:14
@betsyecastro betsyecastro self-assigned this Oct 8, 2024
@betsyecastro betsyecastro changed the title 🦺 Adds student research form validations Adds student research form validations Oct 10, 2024
@betsyecastro betsyecastro marked this pull request as draft October 25, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wunc wunc Awaiting requested review from wunc

Assignees

@betsyecastro betsyecastro

Labels
✨ enhancement New feature or request ⚡️ performance Related to performance or efficiency 🔒 security Security-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@betsyecastro