Upgrade packages, change tag/target syntax (#23) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building an image, the Alpine package index is updated in order to install various dependencies. The versions installed depend on the state of the package index at that time. One therefore does not necessarily get the same packages when building `ghc-musl` images at different times; images are not reproducible in this way. This commit adds a command to upgrade any already-installed packages after the package index is updated. This ensures that the latest packages are used, and that the already-installed packages are consistent with the versions of newly added packages.
Previously, each image was tagged like the following: * `ghc-musl:v24-ghc924` With this commit, each image is now tagged like the following: * `ghc-musl:ghc9.2.4-alpine3.16.1-20220730` * `ghc-musl:ghc9.2.4-alpine3.16.1` * `ghc-musl:ghc9.2.4` This allows users to specify image names according to their needs. An image tagged with the GHC version, Alpine version, and (UTC) build date never changes. An image tagged with just the GHC version and Alpine version may be updated to include minor/security package releases, but the fixed Alpine version means that major upgrades should not break builds. An image tagged with just the GHC version may be updated to include new package releases, both major and minor. The Earthly targets are renamed to match the new tags. For example, previous target `ghc924` is now named `ghc9.2.4`. Note that updating the GHC-only tag should be done with caution, so that it always points to an image using the latest (supported) Alpine version. To facilitate this, the `image` target has a `TAG_GHC` argument that defaults to `0` so that the GHC-only tag is not saved by default. This argument should be set to `1` only when updating the image using the latest (supported) Alpine version. The following command is an example of using this argument when building locally: ``` $ earthly --allow-privileged --build-arg TAG_GHC=1 +ghc9.2.4 ``` The `ALPINE_VERSION` variable is still set to the latest (supported) Alpine version, *not* set to `latest`. Users who would like to use the `latest` image are still able to do so by specifying it in a build argument.
utdemir
approved these changes
Jul 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the changes discussed in #23. Please see the commit messages of the two commits for details.