Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement card 'Ragnaros the Firelord' (EX1_298) #477

Merged
merged 2 commits into from
Aug 15, 2020

Conversation

rapsealk
Copy link
Contributor

@rapsealk rapsealk commented Aug 12, 2020

This revision includes:

  • Implement card 'Ragnaros the Firelord' (EX1_298)

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #477 into impl-card will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           impl-card     #477      +/-   ##
=============================================
+ Coverage      97.30%   97.36%   +0.05%     
=============================================
  Files            269      269              
  Lines          46446    46493      +47     
=============================================
+ Hits           45193    45266      +73     
+ Misses          1253     1227      -26     

@utilForever utilForever self-requested a review August 13, 2020 02:30
@utilForever utilForever changed the title feat(impl-card): Implement card 'Ragnaros the Firelord' (EX1_298) Implement card 'Ragnaros the Firelord' (EX1_298) Aug 15, 2020
Copy link
Owner

@utilForever utilForever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that I moved the position of the code to improve readability. Thanks for your work! 😄

@utilForever utilForever merged commit 6cdcfca into utilForever:impl-card Aug 15, 2020
@rapsealk rapsealk deleted the impl-card branch September 1, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants