Enforce our 7 day TTL on certificates #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcrowe
commented
Oct 30, 2023
| message: "renewBefore must be unset of set to 2/3 of duration, which is required to be 168hrs currently (7 days)" | ||
| pattern: | ||
| spec: | ||
| =(renewBefore): "112" |
There was a problem hiding this comment.
Not sure if you can reference the duration field & calculate 2/3rds dynamically?
For now as duration is a fixed value, this seemed fine.
Certificates must be issued for 7 days and start renewing 2/3rds of the way through.
rcrowe
force-pushed
the
enforce-duration-field-for-shared-kafka
branch
from
7cfa08a to
4bb8046
Compare
| operator: Equals | ||
| value: kafka-shared-selfsigned-issuer | ||
| validate: | ||
| message: "Duration must be set to 168h (7 days) as per our recommended best practices" |
There was a problem hiding this comment.
per our recommended best practices
Where are these best recommendations documented (could we link to that here)?
| operator: Equals | ||
| value: kafka-shared-selfsigned-issuer | ||
| validate: | ||
| message: "renewBefore must be unset or set to 2/3 of duration, which is required to be 168hrs currently (7 days)" |
There was a problem hiding this comment.
Might help make it very clear where this value comes from
Suggested change
| message: "renewBefore must be unset or set to 2/3 of duration, which is required to be 168hrs currently (7 days)" | |
| # 2/3 of value defined in ./require-default-duration.yaml | |
| message: "renewBefore must be unset or set to 2/3 of duration, which is required to be 168hrs currently (7 days)" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certificates must be issued for 7 days and start renewing 2/3rds of the way through.