vm: fix clone incorrect behaviour

The name was not saved and the wrong VM had its ID changed.
utmapp · Dec 21, 2022 · 05bb6d3 · 05bb6d3
1 parent 56de8cf
commit 05bb6d3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/Managers/UTMVirtualMachine.swift b/Managers/UTMVirtualMachine.swift
@@ -110,11 +110,17 @@ extension UTMVirtualMachine: ObservableObject {
     }
 
     /// Called when we have a duplicate UUID
-    @MainActor func changeUuid(to uuid: UUID) {
+    @MainActor func changeUuid(to uuid: UUID, name: String? = nil) {
         if let qemuConfig = config.qemuConfig {
             qemuConfig.information.uuid = uuid
+            if let name = name {
+                qemuConfig.information.name = name
+            }
         } else if let appleConfig = config.appleConfig {
             appleConfig.information.uuid = uuid
+            if let name = name {
+                appleConfig.information.name = name
+            }
         } else {
             fatalError("Invalid configuration.")
         }

diff --git a/Platform/UTMData.swift b/Platform/UTMData.swift
@@ -460,8 +460,8 @@ class UTMData: ObservableObject {
         guard let newVM = UTMVirtualMachine(url: newPath) else {
             throw NSLocalizedString("Failed to clone VM.", comment: "UTMData")
         }
-        await vm.changeUuid(to: UUID())
-        try await vm.saveUTM()
+        await newVM.changeUuid(to: UUID(), name: newName)
+        try await newVM.saveUTM()
         var index = await virtualMachines.firstIndex(of: vm)
         if index != nil {
             index! += 1