settings(iOS): do not evaluate isSupported every view update

utmapp · Jan 2, 2023 · 6d56dc8 · 6d56dc8
1 parent 8445a62
commit 6d56dc8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Managers/UTMQemuVirtualMachine.swift b/Managers/UTMQemuVirtualMachine.swift
@@ -62,7 +62,6 @@ public extension UTMQemuVirtualMachine {
         #endif
         let frameworksURL = contentsURL.appendingPathComponent("Frameworks", isDirectory: true)
         let framework = frameworksURL.appendingPathComponent("qemu-" + arch + "-softmmu.framework/" + base + "qemu-" + arch + "-softmmu", isDirectory: false)
-        logger.error("\(framework.path)")
         return FileManager.default.fileExists(atPath: framework.path)
     }
 

diff --git a/Platform/Shared/VMConfigSystemView.swift b/Platform/Shared/VMConfigSystemView.swift
@@ -159,6 +159,7 @@ private struct HardwareOptions: View {
     @Binding var warningMessage: WarningMessage?
     @EnvironmentObject private var data: UTMData
     @State private var isArchitectureFirstAppear: Bool = true
+    @State private var isArchitectureSupported: Bool = true
     @State private var isTargetFirstAppear: Bool = true
 
     var body: some View {
@@ -176,11 +177,12 @@ private struct HardwareOptions: View {
                     }
                 }
                 .onChange(of: config.architecture) { newValue in
+                    isArchitectureSupported = UTMQemuVirtualMachine.isSupported(systemArchitecture: newValue)
                     if newValue != architecture {
                         architecture = newValue
                     }
                 }
-            if !UTMQemuVirtualMachine.isSupported(systemArchitecture: config.architecture) {
+            if !isArchitectureSupported {
                 Text("The selected architecture is unsupported in this version of UTM.")
                     .foregroundColor(.red)
             }