-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New VM Launch Returns Error: Identifiers consist of letters… when placed image file in .UTM manually #3388
Comments
Thanks for providing the debug information; however you did not describe what steps you took in UTM to produce this error. I just tested the following steps to try and reproduce the issue, but it did not occur. (UTM does not use UUID for the image name, unless you add a 1001st image to the VM [UTMData.swift L157-176]. The code you referenced has been changed significantly.)
Expected result: the Config PLIST includes the drive with "name" property "drive0". Actual result: see expected. If these steps produce a different result for you or if you have different steps that lead to this issue, please re-open. |
Sorry I missed that. Here are the steps I took, but I think it is obvious they wouldn't reproduce the issue consistently if the same random ID is causing the same issue:
FWIW, these steps were taken due to searching in the issues section and seeing that .vhd files aren't supported or planned to be in the future (didn't look at the date) with advice to search the Internet for how to convert them. It is possible these steps should not be taken anymore and .vhd files are now supported. |
Thank you @The00Dustin for the steps. This is indeed a different code path from what I was investigating. I’ll have to check that out later and see where the bug is hiding (note to self: orphaned files detection). In the mean time please use the Import feature instead of placing files in the |
QEMU drive ids must start with a letter. However if an image files was manually placed in the VM images folder, this code path is triggered and a UUID set for the id. This causes ids starting with numbers to be set sometimes. This commit changes the name for these drives to use sequential driveX numbering instead of UUID.
As suspected the bug is in the code that adds "orphaned" drive files to the configuration: UTM/Configuration/UTMConfiguration+Drives.m Lines 104 to 110 in 6524c73
Here in line 107 the UUID string is used as the name without the usual "drive" prefix. A fix could be to change the code to use sequential numbers for the drive names: NSString *name = [NSString stringWithFormat:@"drive%ld", [self countDrives]]; |
QEMU drive ids must start with a letter. However if an image files was manually placed in the VM images folder, this code path is triggered and a UUID set for the id. This causes ids starting with numbers to be set sometimes. This commit changes the name for these drives to use driveUUID naming to definitively work around name collisions.
…ed-drive Fix #3388 invalid drive id for manually placed files
Describe the issue
Error popup stating
Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
while trying to launch new VM.New VM includes qcow2 file generated using qemu-img installed using brew.
Configuration
Crash log
No crash reports in Console, no file names containing "qemu" in log reports section, either.
Debug Log
debug.log
Upload VM
config.plist.txt
config.plist includes this:
It seems plausible this could be the same as closed issue #2614 for iOS. In this case, can I edit that string in the plist file to start with a letter as a workaround?
The text was updated successfully, but these errors were encountered: