Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wizard(apple): proper support for ISO disk drives #3472

Closed
ktprograms opened this issue Jan 13, 2022 · 6 comments
Closed

wizard(apple): proper support for ISO disk drives #3472

ktprograms opened this issue Jan 13, 2022 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@ktprograms
Copy link
Contributor

ktprograms commented Jan 13, 2022

If I download the Alpine Linux 3.15 virt aarch64 ISO and extract the vmlinuz and initramfs from it, I can then use the whole ISO as the rootfs.

This causes a problem because 60ac313 makes it that putting a ISO in the rootfs field will cause a disk image to not be created, which is wrong.

I propose adding a ISO field that will also be marked as read only, since you can't write to an ISO.

(followup to #3461 (comment))

@ktprograms ktprograms added the enhancement New feature or request label Jan 13, 2022
@osy osy added this to the v3.0 milestone Jan 13, 2022
@osy osy closed this as completed in 007f9d4 Jan 13, 2022
@osy
Copy link
Contributor

osy commented Jan 13, 2022

The one thing I don't like about this is that it makes the wizard flow more complicated for Linux now. Please test and try to see if any edge cases break the wizard. Thanks.

@ktprograms
Copy link
Contributor Author

@osy since the current code isn't making it read only anyway, I think the simplest thing to do is to revert this commit and just add a checkbox for Skip creation of disk.

FYI If you do git rebase -i HEAD~2 and in the editor change the word pick to drop on line with 007f9d4, that will remove the commit without creating another revert commit. (you will have to force push after that)

@osy
Copy link
Contributor

osy commented Jan 13, 2022

8eacd8f now makes it read-only. Is that all?

@ktprograms
Copy link
Contributor Author

Also a HStack around the Browse and Clear buttons for the Boot ISO Image is needed, thanks

I'll do some proper testing and let you know

osy added a commit that referenced this issue Jan 13, 2022
@ktprograms
Copy link
Contributor Author

@osy It's working fine so far, but it seems that 60ac313 doesn't work properly. It skips the disk creation wizard step, but a 64 GB disk is still created.

@osy
Copy link
Contributor

osy commented Jan 13, 2022

Fixed in ceb6f91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants