Skip to content

feat: pass umi config mako #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorrycc merged 4 commits into from
Jul 10, 2024
Merged

feat: pass umi config mako #1394

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
503ce5d
feat: pass umi config mako
xiaohuoni Jul 10, 2024
08d0644
chore: reset code
xiaohuoni Jul 10, 2024
649c4c6
chore: reset code
xiaohuoni Jul 10, 2024
d7ebb0d
chore: remove moduleIdStrategy
xiaohuoni Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/bundler-mako/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,21 @@ function checkConfig(opts) {
assert(!opts.config[key], `${key} is not supported in Mako bundler`);
});

// 支持透传给 mako 的配置
const supportMakoConfigKeys = [
'px2rem',
'experimental',
'flexBugs',
'optimization',
];
// umi mako config
const { mako } = opts.config;
Object.keys(mako).forEach((key) => {
assert(
supportMakoConfigKeys.includes(key),
`umi config mako.${key} is not supported`,
);
});
// 暂不支持 { from, to } 格式
const { copy } = opts.config;
if (copy) {
Expand Down Expand Up @@ -441,7 +456,9 @@ async function getMakoConfig(opts) {
inlineCSS,
makoPlugins,
analyze,
mako,
} = opts.config;

let { codeSplitting } = opts.config;
// TODO:
// 暂不支持 $ 结尾，等 resolve 支持后可以把这段去掉
Expand Down Expand Up @@ -607,6 +624,7 @@ async function getMakoConfig(opts) {
},
plugins: makoPlugins || [],
analyze: analyze || process.env.ANALYZE ? {} : undefined,
...mako,
};

return makoConfig;
Expand Down