feat: detect circular dependencies support ignore config#1425
feat: detect circular dependencies support ignore config#1425
Conversation
演练这次更改主要涉及替换和更新插件系统中的循环检测功能。具体来说，将 更改
序列图sequenceDiagram
participant User
participant Compiler
participant Plugins
participant Config
User ->> Compiler: 发起编译请求
Compiler ->> Plugins: 加载 LoopDetector 插件
Plugins ->> detect_circular_dependence: 使用新插件
detect_circular_dependence ->> Compiler: 返回检测结果
Compiler ->> Config: 读取新配置
Config ->> Compiler: 应用配置
Compiler ->> User: 返回编译结果
诗歌
🐰✨ Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
crates/mako/src/plugins/loop_circular_dependence.rs (1)
19-19: 更新循环依赖检测逻辑不完整检测循环依赖的逻辑更新不完整。仍然存在多个
detect_loop的实例，这些实例应替换为detect_circular_dependence以确保一致性和正确性。请更新以下位置：
crates/mako/src/plugins/loop_circular_dependence.rs:
- 第 19 行
- 第 26 行
- 第 43 行
crates/mako/src/config/config.rs:
- 第 1 行
- 第 22 行
Analysis chain
更新循环依赖检测逻辑
检测循环依赖的逻辑已更新，使用
detect_circular_dependence代替detect_loop。请确保所有对该函数的调用都已更新。Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `detect_circular_dependence` match the new signature. # Test: Search for the function usage. Expect: Only occurances of the new signature. rg --type rust -A 5 $'detect_circular_dependence'Length of output: 995
Script:
#!/bin/bash # Description: Verify all instances of the old `detect_loop` have been replaced with `detect_circular_dependence`. # Test: Search for the old function usage. Expect: No occurrences of `detect_loop`. rg --type rust -A 5 $'detect_loop'Length of output: 2623
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- crates/mako/src/compiler.rs (1 hunks)
- crates/mako/src/config/config.rs (4 hunks)
- crates/mako/src/plugins/loop_circular_dependence.rs (3 hunks)
- crates/mako/src/plugins/mod.rs (1 hunks)
- packages/bundler-mako/index.js (1 hunks)
Additional comments not posted (11)
crates/mako/src/plugins/mod.rs (1)
11-11: 重命名模块以反映新的功能
loop_detector模块已重命名为loop_circular_dependence，这更好地反映了其检测循环依赖的功能。crates/mako/src/plugins/loop_circular_dependence.rs (4)
15-15: 更新插件名称
name方法的返回值已更新为 "loop_circular_dependence"，这更准确地反映了插件的功能。
25-33: 引入忽略特定正则模式的功能引入了忽略特定正则模式的功能，以便在循环依赖检测中过滤掉噪音。确保正则模式正确编译并处理错误。
38-40: 添加忽略正则模式的过滤逻辑添加了忽略特定正则模式的过滤逻辑，以便在循环依赖检测中排除噪音。
66-66: 更新循环依赖警告信息警告信息已更新，以反映检测到的循环依赖。
crates/mako/src/compiler.rs (1)
240-240: 替换循环依赖检测插件将
LoopDetector插件替换为来自loop_circular_dependence模块的LoopDetector。确保新插件已正确集成并且不会破坏任何功能。packages/bundler-mako/index.js (1)
627-634: 引入实验性配置
experimental对象现在包含 webpack 语法验证、require 上下文和循环依赖检测的配置。确保新设置已正确集成并且不会破坏任何功能。crates/mako/src/config/config.rs (4)
104-104: 代码更改通过。宏
create_deserialize_fn!用于创建DetectCircularDependence的反序列化函数，这与结构体重命名一致。
431-433: 代码更改通过。结构体
DetectCircularDependence定义了ignores和graphviz字段，符合检测循环依赖的目的。
442-442: 代码更改通过。
ExperimentalConfig结构体现在包含detect_circular_dependence字段，这将新的DetectCircularDependence结构体集成到实验配置中。
718-718: 代码更改通过。默认配置 JSON 现在使用
detectCircularDependence，包含ignores和graphviz字段，反映了新结构和字段。
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- crates/mako/src/compiler.rs (1 hunks)
- crates/mako/src/plugins/detect_circular_dependence.rs (3 hunks)
- crates/mako/src/plugins/mod.rs (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- crates/mako/src/compiler.rs
- crates/mako/src/plugins/mod.rs
Additional comments not posted (6)
crates/mako/src/plugins/detect_circular_dependence.rs (6)
15-15: 更改名称方法的返回值。该方法的返回值从 "loop_detector" 更改为 "loop_circular_dependence" 符合重命名目标。
19-19: 确保检测循环依赖的配置存在。此代码段确保只有在配置存在且不处于监视模式时才进行循环依赖检测。
25-33: 处理忽略的正则表达式。此代码段处理配置中的忽略正则表达式，并在正则表达式无效时返回错误。
38-40: 过滤循环依赖以排除忽略的模块。此代码段根据忽略的正则表达式过滤循环依赖，确保只有未被忽略的循环依赖会被处理。
66-66: 输出循环依赖警告。此代码段输出检测到的循环依赖警告信息。
76-76: 返回操作结果。此代码段确保函数返回
Ok(())表示操作成功。
2 participants
ignoresconfig, to filter out noise circlesSummary by CodeRabbit
新功能
优化
修复