Skip to content

perf(tree-shaking): ⚡️ use take instead of clone #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stormslowly merged 1 commit into from
Jul 19, 2024
Merged

perf(tree-shaking): ⚡️ use take instead of clone #1429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/mako/src/plugins/tree_shaking/shake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ use std::sync::Arc;

use anyhow::Result;
use swc_core::common::comments::{Comment, CommentKind};
use swc_core::common::util::take::Take;
use swc_core::common::{DUMMY_SP, GLOBALS};

use self::skip_module::skip_module_optimize;
Expand Down Expand Up @@ -256,11 +257,11 @@ pub fn optimize_modules(module_graph: &mut ModuleGraph, context: &Arc<Context>)
}

for (module_id, tsm) in &tree_shake_modules_map {
let tsm = tsm.borrow();
let mut tsm = tsm.borrow_mut();

if tsm.not_used() {
module_graph.remove_module(module_id);
} else if let Some(swc_module) = &tsm.updated_ast {
} else if let Some(swc_module) = &mut tsm.updated_ast {
module_graph
.get_module_mut(module_id)
.unwrap()
Expand All @@ -269,7 +270,7 @@ pub fn optimize_modules(module_graph: &mut ModuleGraph, context: &Arc<Context>)
.unwrap()
.ast
.as_script_ast_mut()
.body = swc_module.body.clone();
.body = swc_module.body.take();
}
}

Expand Down