fix: dev server don't support publicPath (again)#1436
Conversation
Walkthrough此次更改引入了一个新函数 Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/bundler-mako/index.js (1 hunks)
Additional comments not posted (1)
packages/bundler-mako/index.js (1)
125-130: 验证中间件的正确性中间件集成看起来是正确的,但需要确保中间件正确应用并经过测试。请验证
opts.config.publicPath的所有可能值,并确保processReqURL函数在所有情况下都能正确处理请求 URL。
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/bundler-mako/index.js (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/bundler-mako/index.js
#1398 的后续。
@whyer11
你的逻辑应该是对的。
我之前以为的逻辑是静态资源会 proxy 到 mako(rust) 的 server,我昨天验也只验了 mako(rust) server 的逻辑。刚才看代码发现,我们是基于 express.static 的逻辑才生效的。。
我先把你之前的修改再加回去,但感觉终态应该要走 mako(rust) 的 server。
Summary by CodeRabbit