-
Notifications
You must be signed in to change notification settings - Fork 108
wip chore: 🔧 try macos and windows #1480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f3e65ed
chore: 🔧 try macos and windows
stormslowly 35db800
chore: 🔧 run in more os
stormslowly 75fdf5e
try run in windows
stormslowly 8b9378e
fix: window path
xiaohuoni a74da14
fix: window e2e test
xiaohuoni bfc49b8
fix: window e2e test
xiaohuoni 82889ce
fix: window e2e test
xiaohuoni 8df81f2
fix: window e2e test
xiaohuoni 74c4873
chore: change ci flow
xiaohuoni 20c8f83
chore: change ci flow
xiaohuoni d43ebb1
fix: path cannot find
xiaohuoni 12bc0ba
chore: change ci flow
xiaohuoni 08732da
chore: only windows
xiaohuoni 3d0ec6b
fix: winpath
xiaohuoni 574b63a
chore: reset code
xiaohuoni ff9c29c
chore: add debug code
xiaohuoni d1933e5
chore: add debug code
xiaohuoni 84a30ff
fix: import winpath
xiaohuoni 17da4b0
fix: import file path
xiaohuoni 48bc3d6
chore: on windows absolute paths must be valid file:// URLs
xiaohuoni d51557f
chore: on windows absolute paths must be valid file:// URLs
xiaohuoni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import path from 'path'; | ||
|
|
||
| function winPath(path) { | ||
| const isExtendedLengthPath = /^\\\\\?\\/.test(path); | ||
| if (isExtendedLengthPath) { | ||
| return path; | ||
| } | ||
|
|
||
| return path.replace(/\\/g, '/'); | ||
| } | ||
|
|
||
| export function winJoin(...args) { | ||
| return winPath(path.join(...args)); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.