revert: 1509 and 1475 #1538
revert: 1509 and 1475 #1538
Conversation
This reverts commit 7213a37.
|
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (1)
You can disable this status message by setting the Walkthrough本次更改涉及Mako项目的多个文件，主要包括依赖项的更新、源地图处理逻辑的简化以及模块依赖管理策略的调整。新依赖 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Mako
participant SourceMap
User->>Mako: 请求生成源地图
Mako->>SourceMap: 合并源地图
SourceMap-->>Mako: 返回合并后的源地图
Mako-->>User: 返回生成结果
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
Files selected for processing (7)
- crates/mako/Cargo.toml (1 hunks)
- crates/mako/src/ast/sourcemap.rs (5 hunks)
- crates/mako/src/generate/chunk_pot/ast_impl.rs (3 hunks)
- crates/mako/src/generate/group_chunk.rs (2 hunks)
- crates/mako/src/generate/optimize_chunk.rs (1 hunks)
- crates/mako/src/module_graph.rs (2 hunks)
- crates/mako/src/stats.rs (1 hunks)
Files skipped from review due to trivial changes (1)
- crates/mako/Cargo.toml
Additional comments not posted (14)
crates/mako/src/ast/sourcemap.rs (4)
48-48: LGTM!
RawSourceMap结构体的更新与新的 source map 处理方式一致。代码更改已批准。
Line range hint
54-64: LGTM!
impl From<sourcemap::SourceMap> for RawSourceMap的更新与新的 source map 处理方式一致。代码更改已批准。
Line range hint
69-79: LGTM!
impl From<RawSourceMap> for sourcemap::SourceMap的更新与新的 source map 处理方式一致。代码更改已批准。
81-101: LGTM!
merge_source_map函数的更新简化了代码，增强了可读性和可维护性。代码更改已批准。
crates/mako/src/generate/chunk_pot/ast_impl.rs (1)
Line range hint
18-100: LGTM!
render_css_chunk函数的更新简化了代码，增强了可读性和可维护性，同时通过简化控制流可能提高了性能。代码更改已批准。
crates/mako/src/module_graph.rs (1)
6-6: 请验证删除的影响。
get_dependencies_by_link_back_dfs函数的删除表明模块图中的依赖管理方式发生了重大变化。请确保此删除不会破坏任何现有功能。请运行以下脚本以验证此删除的影响：
Verification successful
验证成功：删除
get_dependencies_by_link_back_dfs函数没有影响。在代码库、测试文件和文档中均未找到对该函数的引用，表明其删除不会破坏现有功能。此更改是安全的。
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the impact of removing `get_dependencies_by_link_back_dfs`. # Test: Search for the function usage. Expect: No occurrences of the old function. rg --type rust -A 5 $'get_dependencies_by_link_back_dfs'Length of output: 55
Script:
#!/bin/bash # Description: Check for any tests or documentation referencing `get_dependencies_by_link_back_dfs`. # Search for references in test files rg --type rust -A 5 'get_dependencies_by_link_back_dfs' --glob '*test*' # Search for references in documentation files rg --type markdown -A 5 'get_dependencies_by_link_back_dfs'Length of output: 131
crates/mako/src/generate/group_chunk.rs (5)
391-391: 初始化visited_modules向量初始化
visited_modules向量是正确的，并且符合维护 DFS 顺序的新逻辑。代码更改已批准。
396-399: 使用position方法确定parent_index使用
position方法确定parent_index是合适的，可以保持正确的插入顺序。代码更改已批准。
421-421: 收集当前 head 的普通依赖项收集当前 head 的普通依赖项是正确的，并且符合新逻辑。
代码更改已批准。
427-428: 在 head 之前插入普通依赖项在 head 之前插入普通依赖项是正确的，并确保维护 DFS 顺序。
代码更改已批准。
434-435: 按 DFS 顺序将模块添加到 chunk 中按 DFS 顺序将模块添加到 chunk 中是正确的，并符合预期的遍历顺序。
代码更改已批准。
crates/mako/src/stats.rs (2)
128-131: 使用iter().last()代替back()方法使用
iter().last()改进了访问最后一个模块的清晰度和一致性。代码更改已批准。
133-133: 在默认情况下使用iter().last()代替back()方法在默认情况下使用
iter().last()确保了一致性。代码更改已批准。
crates/mako/src/generate/optimize_chunk.rs (1)
128-128: 使用iter().last()代替chunk.modules.back()方法使用
iter().last()改进了清晰度，并可能更优雅地处理空集合。代码更改已批准。
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1538 +/- ##
==========================================
- Coverage 61.03% 60.78% -0.25%
==========================================
Files 127 126 -1
Lines 15120 15028 -92
==========================================
- Hits 9228 9135 -93
- Misses 5892 5893 +1 ☔ View full report in Codecov by Sentry. |
1 participant
There are some bugs.
Summary by CodeRabbit