Skip to content

fix: devserver response header add cacheControl no-cache #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stormslowly merged 3 commits into from
Nov 21, 2024
Merged

fix: devserver response header add cacheControl no-cache #1692

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7311f34
fix: add no-cache
Jinbao1001 Nov 15, 2024
0b0fb82
feat: add cross origin
Jinbao1001 Nov 20, 2024
1a984f8
Merge remote-tracking branch 'origin/master' into fix/browser_cache
Jinbao1001 Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/mako/src/dev.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use anyhow::{self, Result};
use colored::Colorize;
use futures::{SinkExt, StreamExt};
use get_if_addrs::get_if_addrs;
use hyper::header::CONTENT_TYPE;
use hyper::header::{ACCESS_CONTROL_ALLOW_ORIGIN, CACHE_CONTROL, CONTENT_TYPE};
use hyper::service::{make_service_fn, service_fn};
use hyper::{Body, Request, Server};
use notify_debouncer_full::new_debouncer;
Expand Down Expand Up @@ -179,6 +179,8 @@ impl DevServer {

return Ok(hyper::Response::builder()
.status(hyper::StatusCode::OK)
.header(CACHE_CONTROL, "no-cache")
Copy link

@petercat-assistant petercat-assistant bot Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that adding the Cache-Control: no-cache header does not interfere with other caching mechanisms or headers that might be required for different environments or use cases. Consider making this configurable if necessary.

.header(ACCESS_CONTROL_ALLOW_ORIGIN, "*")
.header(CONTENT_TYPE, content_type)
.body(hyper::Body::from(res))
.unwrap());
Expand Down