Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions crates/mako/src/features/node.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,13 @@ impl Node {
config.targets = HashMap::from([("node".into(), *target)]);
// ignore all built-in node modules
config.ignores.push(format!(
"^(node:)?({})(/.+|$)",
Self::get_all_node_modules().join("|")
"^({})(/.+|$)",
Self::get_all_builtin_modules_besides_node_prefixed_only().join("|")
));
config.ignores.push(format!(
"^node:({})(/.+|$)",
Self::get_all_builtin_modules().join("|")
));
// If it starts with "node:", they are all built-in node modules.
config.ignores.push("^(node:)(.+)".to_string());
// polifyll __dirname & __filename is supported with MockFilenameAndDirname Visitor
} else {
// polyfill __dirname & __filename for browser
Expand Down Expand Up @@ -125,7 +127,17 @@ impl Node {
.collect()
}

fn get_all_node_modules() -> Vec<String> {
fn get_node_prefixed_only_builtin_modules() -> Vec<String> {
["sqlite", "test"].iter().map(|s| s.to_string()).collect()
}

fn get_all_builtin_modules() -> Vec<String> {
let mut modules = Self::get_all_builtin_modules_besides_node_prefixed_only();
modules.extend(Self::get_node_prefixed_only_builtin_modules());
modules
}

fn get_all_builtin_modules_besides_node_prefixed_only() -> Vec<String> {
let mut modules = Self::get_polyfill_modules();
modules.extend(Self::get_empty_modules());
modules
Expand Down
1 change: 1 addition & 0 deletions e2e/fixtures/config.platform.node/expect.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,4 @@ assert.match(
"should transform __dirname"
);
assert(content.includes(`require('crypto');`), `should keep require for crypto`);
assert(content.includes(`require('node:sqlite');`), `should keep require for node:sqlite`);
2 changes: 2 additions & 0 deletions e2e/fixtures/config.platform.node/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,5 @@ try {
} catch {
hasCrypto = false
}

require('node:sqlite');
Loading