-
Notifications
You must be signed in to change notification settings - Fork 108
fix: registry url #2525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
fix: registry url #2525
Conversation
Summary of ChangesHello @elrrrrrrr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the reliability of registry URL handling within the application. By introducing URL normalization and propagating potential errors through Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly implements registry URL normalization using reqwest::Url. The changes to function signatures to return Result and the propagation of errors using ? are well-executed throughout the codebase. I've added a couple of suggestions to improve code style and test failure diagnostics. Overall, this is a solid improvement.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
📊 Performance Benchmark Report (with-antd)🚀 Utoopack Performance Report: Async Task Scheduling Overhead AnalysisReport ID: 📊 Executive SummaryThis report analyzes the performance of Utoopack/Turbopack, covering the full spectrum of the Performance Analysis Protocol (P0-P4). Key Findings
Workload Distribution by Tier
⚡ Parallelization Analysis (P0-P2)Thread Utilization
Assessment: With 15 threads available, achieving 8.5x parallelism indicates significant loss of potential parallelism. 📈 Top 20 Tasks (Global)These are the most significant tasks by total duration:
🔍 Deep Dive by Tier🔴 Tier 1: Runtime & Resolution (P0)Focus: Task scheduling and dependency resolution.
Potential P0 Issues:
🟠 Tier 2: Physical & Resource Barriers (P1)Focus: Hardware utilization, I/O, and heavy monoliths.
Potential P1 Issues:
🟡 Tier 3: Architecture & Asset Pipeline (P2-P3)Focus: Global state and transformation pipeline.
💡 Recommendations (Prioritized P0-P2)🚨 Critical: (P0) ImprovementProblem: 57.0% thread utilization.
|
| Signal | Status | Finding |
|---|---|---|
| Tracing Noise (P0) | 60.1% of tasks < 10µs | |
| Thread Utilization (P0) | 🚨 Low | 57.0% utilization |
| Heavy Monoliths (P1) | 16 tasks > 100ms | |
| Asset Pipeline (P3) | 🔍 Review | 4,392.2 ms total |
| Bridge/Interop (P4) | ✅ Low | 0.0 ms total |
🎯 Action Items (Comprehensive P0-P4)
- [P0] Profile lock contention to address 43% lost parallelism
- [P1] Breakdown heavy monolith tasks (>100ms) to improve granularity
- [P1] Review I/O patterns for potential batching opportunities
- [P3] Optimize asset transformation pipeline hot-spots
- [P4] Reduce "chatty" bridge operations if interop overhead is significant
Report generated by Utoopack Performance Analysis Agent on 2026-01-28
Following: Utoopack Performance Analysis Agent Protocol
reqwestexp:https://registry.npmmirror.com/////cc @yuzheng14