getRegisterable() doesn't always return the registerable domain only

[artyuum]

Steps to reproduce

$domain = new Domain('http://facebook.com');
$domain2 = new Domain('http://www.facebook.com');

$domain->getRegisterable()); // 'http://facebook.com'
$domain2->getRegisterable()); // 'facebook.com'

[eldadfux]

@artyuum please not the library constructor is expecting a domain or hostname as the first argument and not a URL.

[eldadfux]

You can try and use it this way:

        $domain = new Domain(parse_url('https://www.facebook.com', PHP_URL_HOST));
       
        $this->assertEquals('www.facebook.com', $domain->get());
        $this->assertEquals('com', $domain->getTLD());
        $this->assertEquals('com', $domain->getSuffix());
        $this->assertEquals('facebook.com', $domain->getRegisterable());
        $this->assertEquals('facebook', $domain->getName());
        $this->assertEquals('www', $domain->getSub());
        $this->assertEquals(true, $domain->isKnown());
        $this->assertEquals(true, $domain->isICANN());
        $this->assertEquals(false, $domain->isPrivate());
        $this->assertEquals(false, $domain->isTest());
        
        $domain = new Domain(parse_url('https://facebook.com', PHP_URL_HOST));
       
        $this->assertEquals('facebook.com', $domain->get());
        $this->assertEquals('com', $domain->getTLD());
        $this->assertEquals('com', $domain->getSuffix());
        $this->assertEquals('facebook.com', $domain->getRegisterable());
        $this->assertEquals('facebook', $domain->getName());
        $this->assertEquals('', $domain->getSub());
        $this->assertEquals(true, $domain->isKnown());
        $this->assertEquals(true, $domain->isICANN());
        $this->assertEquals(false, $domain->isPrivate());
        $this->assertEquals(false, $domain->isTest());

[artyuum]

Yup, that's the workaround I found in order to strip the "http(s)://" part. The problem is that no error/exception were returned. Why not use parse_url() internally? Or maybe this is out of the scope of this library?

[eldadfux]

I think detecting if the value is a URL, hostname, or domain might be out of scope, and add unwanted complexity.

I can add a small validation for strings that starts with https:// or http:// and throw an exception because this might be a common mistake.

[artyuum]

I can add a small validation for strings that starts with https:// or http:// and throw an exception because this might be a common mistake.

Agreed.

[eldadfux]

@artyuum, I just pushed a fix, and released a new tag (0.2.2).

[artyuum]

Thank you.

[kwadx]

Hi,

I have had the case of domains starting with "http" (exemple : httpmydomain.com) so the check would fail even if the domain is perfectly valid.

I guess you should check at least for "http:" and "https:"

What do you think ?

[Meldiron]

This has been fixed and released 🥳 Dont hesitate to reopen issue if you still encounter same problem after upgrading.