Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain validity check #12

Closed
wants to merge 1 commit into from
Closed

Fix domain validity check #12

wants to merge 1 commit into from

Conversation

kwadx
Copy link

@kwadx kwadx commented Feb 2, 2022

Domain validation check will fail if a domain starts with "http" or "https". Ex : httpmydomain.com.

Changing "http" and "https" to "http:" and "https:"

Domain validation check will fail if a domain starts with "http" or "https". Ex : httpmydomain.com.

Changing "http" and "https" to "http:" and "https:"
@eldadfux
Copy link
Member

eldadfux commented Feb 2, 2022

This was fixed with additional tests on #13

@eldadfux eldadfux closed this Feb 2, 2022
@eldadfux
Copy link
Member

eldadfux commented Feb 2, 2022

Thank for the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants