Fix: Failing jobs #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meldiron
commented
Aug 29, 2022
| @@ -1,6 +1,7 @@ | |||
| on: | |||
| schedule: | |||
| - cron: "12 3 * * *" | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
This line allows us to trigger jobs manually if ever needed. That becomes really helpful in the future, as it will allow us to test jobs - execute them from a specific branch.
The downside might be security - a person with access to workflow dispatching and making new branches might be able to get hands on some secrets. Would love approval from @eldadfux on this. If not secure, we can revert it.
There was a problem hiding this comment.
As long as forks don't get access to it, we should be fine.
There was a problem hiding this comment.
Forced a push on my fork. It was successful, but it pushed to my fork. Looks like we are using some pre-defined secrets for that, so it should be all safe.
eldadfux
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we return exit code 1 when the existing dataset is up to date. That is a problem for GitHub since it considers such a test failed and shoots notifications at us.
This PR makes sure the job exits successfully even when our data is up to date.
Tested the edge case on a fork:
