-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: utopia compression #146
base: master
Are you sure you want to change the base?
Conversation
composer.json
Outdated
"repositories": { | ||
"utopia-php/compression": { | ||
"type": "git", | ||
"url": "https://github.com/utopia-php/compression" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed now that the package was published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the filename/location is not consistent with what we do in other utopia libs. Maybe we can use the database library or something else for a pattern we can reuse here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you like this?
tests/
e2e/
Server/
SwooleTest.php
FPMTest.php
SwooleCompressionTest.php
...
resources/
init.php
SwooleServer.php
FPMServer.php
SwooleCompressionServer.php
...
Adds
setCompression
configuration method to utopia HttpIf enabled, this performs brotli, gzip, or delate (in decreasing priority) compression on response bodies of requests that:
text/*
etc)accept-encoding
header