Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: catch error handler #156

Merged
merged 6 commits into from
Dec 10, 2024
Merged

fix: catch error handler #156

merged 6 commits into from
Dec 10, 2024

Conversation

loks0n
Copy link

@loks0n loks0n commented Dec 10, 2024 •
edited
Loading

No description provided.

@loks0n loks0n changed the base branch from master to 0.33.x December 10, 2024 10:44
@loks0n loks0n requested a review from Meldiron December 10, 2024 10:45
Meldiron
Meldiron reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me, but lets please add test to ensure this exception if possible

@loks0n loks0n requested a review from christyjacob4 December 10, 2024 11:49
@loks0n
Copy link
Author

loks0n commented Dec 10, 2024

Changes looks good to me, but lets please add test to ensure this exception if possible

added

@loks0n loks0n requested a review from Meldiron December 10, 2024 11:49
@loks0n loks0n merged commit 83b0628 into 0.33.x Dec 10, 2024
4 checks passed
@christyjacob4 christyjacob4 deleted the fix-catch-error-handler branch December 11, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

@christyjacob4 christyjacob4 Awaiting requested review from christyjacob4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loks0n @Meldiron