-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brevo adapter and test suite for the same. #34
base: main
Are you sure you want to change the base?
Add brevo adapter and test suite for the same. #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need ENV vars also?
Does Brevo have regions, or multiple domains?
*/ | ||
public function testSendPlainTextEmail() | ||
{ | ||
// $this->markTestSkipped('Brevo credentials not set.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this?
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove these empty lines?
|
||
public function getMaxMessagesPerRequest(): int | ||
{ | ||
return 1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link the documentation to support this in the PR description or as a response to this comment?
$message->getTo() | ||
), | ||
"subject" => $message->getSubject(), | ||
$bodyKey => $message->getContent(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do the same as in Mailgun.php
'text' => $message->isHtml() ? null : $message->getContent(),
'html' => $message->isHtml() ? $message->getContent() : null,
Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback. We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions and/or ensure the tests pass by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event. Looking forward to your updates and thank you! |
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
my username akhilesh_32621 |
What does this PR do?
This PR implements brevo email adapter.
Test Plan
To execute the Brevo E2E test suite, you will need a Brevo account with certain requirements. Please follow these steps:
Create a Brevo Account:
Set Up Sender Information:
Prepare Email Addresses:
Obtain Brevo API Key:
Install Required PHP Extensions: (For unix-based distributions)
Install PHPUnit and Dependencies:
Run E2E Tests:
YOUR_BREVO_API_KEY
,YOUR_TEST_EMAIL
, andYOUR_TEST_FROM_EMAIL
with your actual Brevo API key, test email address, and from email address, respectively. Ensure thatYOUR_TEST_EMAIL
andYOUR_TEST_FROM_EMAIL
belong to the same domain as your Sender Signature:Video Demonstration
To get a visual walkthrough of running the Brevo E2E test, watch the video provided below:
Loom.Free.Screen.Video.Recording.Software.Loom.-.2.October.2023.1.mp4
Related PRs and Issues
closes: appwrite/appwrite#6384
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
Yes