Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gupshup Messaging Adapter #49

Closed
wants to merge 5 commits into from
Closed

Added Gupshup Messaging Adapter #49

wants to merge 5 commits into from

Conversation

HarshitVashisht11
Copy link

@HarshitVashisht11 HarshitVashisht11 commented Oct 10, 2023

What does this PR do?

This PR implement support for Gupshup in the Utopia PHP messaging library.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

appwrite/appwrite#6863
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@HarshitVashisht11 HarshitVashisht11 changed the title Initial commit Support for Gupshup in the Utophia-php meassaging library Oct 11, 2023
@HarshitVashisht11 HarshitVashisht11 changed the title Support for Gupshup in the Utophia-php meassaging library Support for Gupshup in the Utopia-php meassaging library Oct 11, 2023
@HarshitVashisht11 HarshitVashisht11 changed the title Support for Gupshup in the Utopia-php meassaging library Added Gupshup Messaging Adapter Oct 11, 2023
Copy link
Contributor

@wess wess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include tests and be sure to run linter

Copy link
Contributor

@wess wess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to add tests and run the linter (pint)

@gewenyu99
Copy link

@HarshitVashisht11 Linter and tests are still failing, did you run linter and tests before submitting the PR?

@HarshitVashisht11 HarshitVashisht11 closed this by deleting the head repository Oct 18, 2023
@HarshitVashisht11
Copy link
Author

Hi @wess @gewenyu99 i have made a new PR closing this PR because of some issue in commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants