Feat 6404 smtp2 go messaging adapter #51
Conversation
|
Fixed the linting errors @gewenyu99 |
| @@ -24,49 +24,31 @@ public function __construct( | |||
| ) { | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Why did you remove a bunch of comments in unrelated files?
There was a problem hiding this comment.
I ran the composer lint command and then it removed the comments to resolve the linting errors issue. @gewenyu99
There was a problem hiding this comment.
I ran the composer lint command and then it removed the comments to resolve the linting errors issue.
That doesn't quite make sense...composer lint only checks for lint errors. it shouldn't be modifying anything.
There was a problem hiding this comment.
@stnguyen90 @gewenyu99 Sorry, it was composer format not composer lint. composer format removed those comments because it was causing linting error. However, my files are not causing any linting error.
|
Hey, Due to time constraints, I'm going to mark this PR When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag. Thanks for helping us improve Appwrite! |
Dockerfile
Outdated
| RUN wget -O phpunit https://phar.phpunit.de/phpunit-9.phar && \ | ||
| chmod +x phpunit && \ | ||
| mv phpunit /usr/local/bin/phpunit |
There was a problem hiding this comment.
There shouldn't be any need to add this.
composer.json
Outdated
| "phpunit/phpunit": "9.6.*", | ||
| "phpmailer/phpmailer": "6.8.*", | ||
| "phpunit/phpunit": "^9.6", | ||
| "phpmailer/phpmailer": "^6.8", |
There was a problem hiding this comment.
Let's change this back to using wildcards. Eventually, we want to use wildcards for everything for clarity.
composer.json
Outdated
| "Utopia\\Messaging\\": "src/Utopia/Messaging" | ||
| "Utopia\\Messaging\\": "src/Utopia/Messaging/" |
There was a problem hiding this comment.
Why was this changed? We don't have a trailing slash for other libraries 🧐
| @@ -24,49 +24,31 @@ public function __construct( | |||
| ) { | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
I ran the composer lint command and then it removed the comments to resolve the linting errors issue.
That doesn't quite make sense...composer lint only checks for lint errors. it shouldn't be modifying anything.
docker-compose.yml
Outdated
| @@ -2,7 +2,12 @@ version: '3.9' | |||
|
|
|||
| services: | |||
| tests: | |||
| image: my-php-app | |||
There was a problem hiding this comment.
There's no need to add this.
There was a problem hiding this comment.
@stnguyen90 @gewenyu99 I have applied the changes suggested by you. The only problem I am facing right now is the linting error caused by those unrelated files. What should I do about it? Composer formatting fixes it by deleting the comments. But is that acceptable?
|
@stnguyen90 @gewenyu99 My tests are succesfull using docker containers. Here is the command |
|
Hello @Ayaan49 Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback. We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions and/or ensure the tests pass by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event. Looking forward to your updates and thank you! |
|
Hello @tessamero , I have already addressed the changes and mentioned the maintainers but I didn't get any reply. Also my tests are passing inside the Docker containers and I have provided ss of the same. Please look into it and tell me if it's ok or not. |
|
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
|
@gewenyu99 |
|
Will try to reach out soon, compiling everyone's names (there's a lot!). Appreciate your patience. |
What does this PR do?
Added SMTP2GO messaging adapter to improve Appwrite messaging.
Test Plan
I created a free SMTP2GO plan, developed the adapter, and tested it by creating a test file inside the "tests" directory. I added the SMTP2GO credentials through environment variables in the Docker Compose file to connect with my SMTP2GO account and verify if emails are being sent. It sent emails successfully. I ran the test case, and it executed without any issues. The command used to run the test case is
docker exec -it messaging-tests-1 ./vendor/bin/phpunit tests/e2e/Email/Smtp2goTest.php. All testing was conducted within Docker containers.Related PRs and Issues
appwrite/appwrite#6404
Have you read the Contributing Guidelines on issues?
Yes