Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Mandrill email adapter #60

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

omjikush09
Copy link

@omjikush09 omjikush09 commented Oct 18, 2023

What does this PR do?

Added Mandrill email adapter

Test Plan

Not able to verify as was getting SSL error

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

yes

Copy link
Contributor

@loks0n loks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! 🚀

Can you fix the linter error?

Also, does Mandrill have regions that we can support?

*/
public function getMaxMessagesPerRequest(): int
{
return 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to the documentation to support this?

"to" => \array_map(
fn ($to) => ['email' => $to],
$message->getTo()
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably your linter problem

content: $content,
);

$response =json_decode($sender->send($message))[0];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$response =json_decode($sender->send($message))[0];
$response = json_decode($sender->send($message))[0];

@tessamero
Copy link

Hello @omjikush09

Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback.

We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions and/or ensure the tests pass by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event.

Looking forward to your updates and thank you!

@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@omjikush09
Copy link
Author

Discord username- omjikush09

@gewenyu99
Copy link

Hey, going through the PRs and collecting everyone's Discord names in a giant spread sheet. There's a lot of PRs so I thank you for your amazing patience.

@gewenyu99
Copy link

Sent you a invite on Discord @omjikush09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants