feat: geosms adapter #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loks0n
commented
Nov 7, 2023
| @@ -30,5 +31,8 @@ public function testSendEmail() | |||
| $response = $sender->send($message); | |||
|
|
|||
| $this->assertEquals($response, ''); | |||
| */ | |||
|
|
|||
| $this->markTestSkipped('Sendgrid: Authenticated user is not authorized to send mail'); | |||
There was a problem hiding this comment.
We need to fix our Sendgrid setup
There was a problem hiding this comment.
@christyjacob4 Do we have a team test account set up for Sendgrid? I think tests here are still using a personal account
loks0n
commented
Nov 7, 2023
tests/e2e/SMS/Msg91Test.php
Outdated
| // $this->assertEquals('success', $result['type']); | ||
|
|
||
| $this->markTestSkipped('Msg91 requires business verification to use template and SMS api.'); | ||
| $this->assertEquals('success', $result['type']); |
There was a problem hiding this comment.
This test is fixed now we are verified
There was a problem hiding this comment.
https://api.msg91.com/apidoc/textsms/send-sms-flow.php
I removed this check since the message property is not really the content instead some sort of an ID that we cannot use for assertion
eldadfux
reviewed
Nov 7, 2023
eldadfux
approved these changes
Nov 7, 2023
stnguyen90
reviewed
Nov 7, 2023
abnegate
reviewed
Nov 7, 2023
| @@ -30,5 +31,8 @@ public function testSendEmail() | |||
| $response = $sender->send($message); | |||
|
|
|||
| $this->assertEquals($response, ''); | |||
| */ | |||
|
|
|||
| $this->markTestSkipped('Sendgrid: Authenticated user is not authorized to send mail'); | |||
There was a problem hiding this comment.
@christyjacob4 Do we have a team test account set up for Sendgrid? I think tests here are still using a personal account
abnegate
approved these changes
Nov 10, 2023
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEO aware SMS adapter that has Twilio as a global default but can also delegate work to local providers.