Refactor Error Handling #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldadfux
reviewed
Feb 22, 2024
eldadfux
approved these changes
Feb 22, 2024
|
Need to get #26 merged into |
Meldiron
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how Errors are handled to allow for easier error reporting from sources.
This PR must be released as a new minor version to maintain compatibility with previous Appwrite versions.
It starts to move away from the
cachebeing the single source of truth surrounding a migration by allowing both Source and Destination to store an array of errors both encountered. This fixes an issue that made it hard to keep a detailed record of issues that sources ran into as errors are now no longer tied to a specific resource