Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GenerateEmbeddedJreTask to generate JRE #740

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add GenerateEmbeddedJreTask to generate JRE #740

wants to merge 3 commits into from

Conversation

chippmann
Copy link
Contributor

Resolves #163

@chippmann
Add GenerateEmbeddedJreTask to create custom JRE
d4bb2a5 
Introduced GenerateEmbeddedJreTask for generating a trimmed JRE using jlink. Added task registration in setupTasks to facilitate custom JRE creation during the build process. This helps minimize the bundled JRE size tailored to specific needs.
@chippmann
Move registration out of after evaluate
b5d2f6a
@chippmann
Improve task api and update docs
3b3a2b2
@chippmann
Copy link
Contributor Author

I opted against implementing more sophisticated tasks like an export task (like we have for the harness/tests project) as these are highly project specific and not hard to implement. Hence in my opinion, it's not worth shipping such tasks as part of our project

CedNaru
CedNaru requested changes Nov 3, 2024
View reviewed changes
Copy link
Member

@CedNaru CedNaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a new task in the godot editor plugin to generate it as well, right next to the Kotlin project generation.

kt/plugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/tasks/GenerateEmbeddedJreTask.kt
)

@Input
var outputDir: String = "jvm/jre-${getArch()}-${getOs()}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we should declare the jvm directory path in the tool-common directory, to avoid hardcoding it here.

kt/plugins/godot-gradle-plugin/src/main/kotlin/godot/gradle/tasks/GenerateEmbeddedJreTask.kt
)

@Input
var javaHome: String = System.getProperty("java.home")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we potentially use the JVM running the gradle task if JAVA_HOME is not set ? Also can we make sure it's at least 11 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CedNaru CedNaru CedNaru requested changes

@piiertho piiertho Awaiting requested review from piiertho

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
topic:gradle-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement JRE generation task
2 participants
@chippmann @CedNaru