Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cargo.toml custom metadata to specify playground features #223

Closed
dtolnay opened this issue May 12, 2018 · 0 comments
Closed

Use Cargo.toml custom metadata to specify playground features #223

dtolnay opened this issue May 12, 2018 · 0 comments

Comments

@dtolnay
Copy link
Contributor

dtolnay commented May 12, 2018

Is your feature request related to a problem? Please describe.

The Rust playground at https://play.rust-lang.org/ would like to move from using a "playground" feature to using Cargo.toml custom metadata to specify enabled features on the playground. This crate is the last one still using a "playground" feature.

Describe the solution you'd like

Please remove the "playground" feature and specify playground features through custom metadata instead, as already done for docs.rs metadata.

[package.metadata.playground]
features = ["serde", "v1", "v3", "v4", "v5"]

Is it blocking?

The existing support for a "playground" feature will be removed imminently.

Describe alternatives you've considered

You're welcome to weigh in on rust-lang/rust-playground#326.

Additional context

uuid/Cargo.toml

Lines 43 to 46 in 7cb0dac

# Get features picked up by the Integer 32 playground. Not public API.
#
# https://play.rust-lang.org
playground = ["serde", "v1", "v3", "v4", "v5"]

bors bot added a commit that referenced this issue May 13, 2018
224: Use custom metadata to specify playground features r=kinggoesgaming a=dtolnay

Fixes #223.

Marking WIP until rust-lang/rust-playground#326 has landed.

Co-authored-by: David Tolnay <dtolnay@gmail.com>
@bors bors bot closed this as completed in #224 May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants