-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defaults and enable features on rust playground #155
Conversation
Thanks @dns2utf8! Do you have a case where you need a random v3 or v5 uuid? My understanding was that those types are typically used to get a consistent uuid value for some other identifier. The thing here I'm not sure of is defaulting to the |
Cargo.toml
Outdated
@@ -1,7 +1,7 @@ | |||
[package] | |||
|
|||
name = "uuid" | |||
version = "0.6.0" | |||
version = "0.6.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't touch version number until preparing a release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
hi @KodrAus I stumbled on uuid after playing on the playground and I would like the playground to include all the features. |
Hi. Thanks for the contribution but I still don't see the need for this. It just feels like we are adding more complexity for no gain. |
One pro would be the crate will work as expected on https://play.rust-lang.org/?gist=118112c0ca3014d3683dfd6db7fa99ef&version=stable |
Ah I see! Yeh there's not a lot you can do without some of the version features enabled. Making Is the |
Yep, but both playgrounds have the same content. |
changes requested were applied but overall approval still needs to go for
My thoughts are that we should go ahead with just the What do you all think? |
👍 from me |
Yeah @KodrAus I agree with that |
@dns2utf8 can you update your branch with master? |
@dns2utf8 can you merge master into defaults branch and fix the conglicts |
@dns2utf8 I want this to be available in |
189: Allow playground defaults r=Dylan-DPC a=kinggoesgaming **I'm submitting a ...** - [ ] bug fix - [x] feature enhancement - [ ] deprecation or removal - [ ] refactor # Description Allow compatibility with play.integer32.com and play.rust-lang.org # Motivation Allows people to use `uuid` in interactive code snippets # Tests Current tests passing # Related Issue(s) Supercedes #155
I tested this change with all features enabled and each one independently enabled.
Current state:
I use this to test this PR: