Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework optional dependencies to discourage direct use as Cargo features #589

Merged
merged 4 commits into from
Feb 13, 2022

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Feb 12, 2022

This affects #588: We've renamed the zerocopy-unstable feature to simply zerocopy. You still need the uuid_unstable RUSTFLAGS cfg to use it, but this avoids starting to accumulate a lot of dead features as they stabilize. That way if we promote zerocopy to a stable feature users don't need to change what features they enable, they can simply stop setting uuid_unstable.

This also renames all of our internal optional dependencies so that they discourage direct use by end-users. Otherwise we'd be stuck in a place where changes to what optional dependencies we use could break any dependents that set those features. Some optional dependencies are pure implementation details that end users shouldn't be tinkering with directly, but some of them aren't. So this tries to distinguish them better.

@KodrAus KodrAus merged commit 5aa53c8 into main Feb 13, 2022
@KodrAus KodrAus deleted the chore/dep-refactor branch March 14, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant