Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test for invalid parse_str #723

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

CXWorks
Copy link

@CXWorks CXWorks commented Dec 9, 2023

Hi,

Thanks for your time & patience to review this PR.

We are researchers focusing on Rust unit tests by LLM. By examine the existing code, we found a unit test can be added to improve the repo's overall unit test coverage(this project is already been well tested).
The code region to cover is:

uuid/src/error.rs

Lines 73 to 79 in c889107

if character as u32 - byte as u32 > 0 {
// Multibyte char
return Error(ErrorKind::Char {
character,
index: index + offset + 1,
});
} else if byte == b'-' {

Thanks again for reviewing.

Copy link
Member

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CXWorks! Nice catch.

@KodrAus KodrAus merged commit 94ecea8 into uuid-rs:main Dec 11, 2023
20 checks passed
kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Jan 19, 2024
Bumps uuid from 1.6.1 to 1.7.0.

Release notes
Sourced from uuid's releases.

1.7.0
What's Changed

Add missing test for invalid parse_str by @​CXWorks in uuid-rs/uuid#723
Upgrade borsh unstable dependency to v1.0 and make it stable by @​bgeron in uuid-rs/uuid#724
Reduce the package size of uuid by @​KodrAus in uuid-rs/uuid#726
Make use of newer Cargo features for specifying dependencies by @​KodrAus in uuid-rs/uuid#727
Prepare for 1.7.0 release by @​KodrAus in uuid-rs/uuid#728

New Contributors

@​CXWorks made their first contribution in uuid-rs/uuid#723
@​bgeron made their first contribution in uuid-rs/uuid#724

Full Changelog: uuid-rs/uuid@1.6.1...1.7.0



Commits

cefc353 Merge pull request #728 from uuid-rs/cargo/1.7.0
3255b54 prepare for 1.7.0 release
403bb17 Merge pull request #727 from uuid-rs/chore/cargo-cleanup
b7c6e26 make use of newer Cargo features for specifying dependencies
ed13c73 Merge pull request #726 from uuid-rs/chore/pkg-size
2e92a3d Merge pull request #724 from bgeron/borsh-1
38f01ff rename workflow
eab4b85 reduce the package size of uuid
421d752 Make the borsh feature work by itself, without having to specify private feat...
2534949 Continue making feature borsh stable, as suggested by @​KordAus
Additional commits viewable in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants