Skip to content

Commit

Permalink
feat: remove deprecated v4 string parameter (#454)
Browse files Browse the repository at this point in the history
In version 1.x of this library it was possible to call `v4('binary')` in
order to receive a byte array instead of a string representation. This
function signature was deprecated in 2.x (but not removed in 3.x as it
should have been).

The correct way to get a binary representation of a uuid is to pass an
array-like object as a second parameter:

```
const buffer = new Array();
v4(null, buffer);
```

Fixes #437.
  • Loading branch information
ctavan authored May 25, 2020
1 parent 4124ec7 commit 88ce3ca
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions src/v4.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@ import rng from './rng.js';
import bytesToUuid from './bytesToUuid.js';

function v4(options, buf, offset) {
if (typeof options === 'string') {
buf = options === 'binary' ? new Uint8Array(16) : null;
options = null;
}

options = options || {};

const rnds = options.random || (options.rng || rng)();
Expand Down

0 comments on commit 88ce3ca

Please sign in to comment.