Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix assignment to readonly property to allow running in strict mode #270

Merged
merged 3 commits into from
Apr 25, 2018
Merged

fix assignment to readonly property to allow running in strict mode #270

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
282c73d
Replaced assignment to readonly Function.name with Object.definePrope…
G-Rath Apr 5, 2018
f0e56c8
added check to make sure the name property is configurable before try…
G-Rath Apr 5, 2018
904a6c1
Removed extra blank newline.
G-Rath Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/v35.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ module.exports = function(name, version, hashfunc) {
return buf || bytesToUuid(bytes);
};

generateUUID.name = name;
// only attempt to set the name if's configurable (which it should be on node > 0.12)
if (Object.getOwnPropertyDescriptor(generateUUID, 'name').configurable) {
Object.defineProperty(generateUUID, 'name', {value: name});
}

// Pre-defined namespaces, per Appendix C
generateUUID.DNS = '6ba7b810-9dad-11d1-80b4-00c04fd430c8';
Expand Down