-
-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bundlesize #353
Add bundlesize #353
Conversation
a99ec8d
to
89cbe46
Compare
@broofa how do you feel about adding bundlesize to this repo (see the additional check in "show all checks")? |
If this is based on #352, can you change the base to |
89cbe46
to
878e626
Compare
Uhm yeah, sorry. I rebased now, should be easy to review. |
2cd9d2d
to
e413cd1
Compare
Sorry for the noise of the many force pushes. I was experiencing flaky browser tests here. It seems that sometimes this await just never returns and the test just stalls there until it hits the jest timeout. I have no clue why, it seems to happen across almost all browsers (haven't seen it in Chrome so far). I'm a bit clueless 🤷♂ . Best bet so far is to just re-run the browser tests through the GitHub actions UI until they don't time out. Anyways, the bundlesize part in this PR is ready for review now. |
This will let us prevent regressions in bundlesize. I chose to monitor the bundlesize of webpack and rollup build because this is what ultimately matters to the user. If we break something in our library that would e.g. break tree shaking in one of these bundlers we would want to notice.
e413cd1
to
4a0034e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #355
4bfde77
to
048df31
Compare
@broofa thanks for the suggestion. You are right, it is better to check the individual versions! However I also want to ensure that we don't break the treeshaking capabilities which is why I don't want to specify the source esmodule files as entrypoints to rollup and webpack, but instead use separate files that explicitly do: import { v1 as uuidv1 } from 'uuid'; Fine for you? (I picked your commit and added an additional change commit, would squash merge everything in here in the end) |
This will let us prevent regressions in bundlesize.
I chose to monitor the bundlesize of webpack and rollup build because this is what ultimately matters to the user. If we break something in our library that would e.g. break tree shaking in one of these bundlers we would want to notice.
Closes #355