test: test imports with npm package contents #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctavan
force-pushed
the
node-esm-wrapper
branch
from
a39089a to
5c133ff
Compare
This simplifies using npm pack in CI tests.
ctavan
force-pushed
the
test-with-nmp-pack
branch
from
88884ec to
ce69bdf
Compare
Especially for publishing CommonJS/ESM/Browser dual packages a lot can go wrong in the actual build and release step, see: https://medium.com/javascript-in-plain-english/is-promise-post-mortem-cab807f18dcc In order to catch regressions with respect to the supported ways of importing this library it makes sense to test this using `npm pack`. Fixes #424
ctavan
force-pushed
the
test-with-nmp-pack
branch
from
ce69bdf to
0912b9b
Compare
|
@LinusU since you brought up the blog post about the failed s-promise update I thought it might be a good idea to add a test for the import and require API using |
|
The last commit I just added is only to show that this would actually catch problems with the npm package contents that are not caught in the tests that run on the source files. I will obviously revert it before merging. |
ctavan
force-pushed
the
test-with-nmp-pack
branch
from
62938b1 to
0912b9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially for publishing CommonJS/ESM/Browser dual packages a lot can go wrong in the actual build and release step, see: https://medium.com/javascript-in-plain-english/is-promise-post-mortem-cab807f18dcc
In order to catch regressions with respect to the supported ways of importing this library it makes sense to test this using
npm pack.Fixes #424