-
-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use Node.js 16.x for building package and tests #601
Conversation
.github/workflows/ci.yml
Outdated
if: matrix.node-version == '12.x' || matrix.node-version == '14.x' | ||
if: matrix.node-version == '16.x' || matrix.node-version == '14.x' | ||
- run: npm run test:pack | ||
if: matrix.node-version == '14.x' | ||
if: matrix.node-version == '16.x' || matrix.node-version == '14.x' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that these two tests should run on >= 12
? That is, all that supports ESM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early versions of 12.x didn't support ESM IIRC… That's why historically we didn't test there.
But I guess nowadays it's safe to run these tests on Node 12+, so thanks for the catch!
Ran into this locally when using npm 7 as well, I didn't have time to look into why there was a |
The |
5f9237b
to
284e2bc
Compare
I had to upgrade @wdio v6 -> v7 in order to get it to run with Node 16 and unfortunately that was a bit of a rabbit hole but it should be good again :). I couldn't resist upgrading all other build deps as well. |
284e2bc
to
e26edd8
Compare
.local/uuid/abc.js
Outdated
@@ -0,0 +1 @@ | |||
sdfkl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be committed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, of course not…. I was Troubleshooting eslint/prettier… will remove
e26edd8
to
76b6ff8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
76b6ff8
to
6559a01
Compare
6559a01
to
4a42846
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! 🙌
Previously we were requiring Node 12.x to get somewhat reproducible npm builds. This now upgrades the requirement to the latests LTS version 16.x