Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove wrapper.mjs #822

Merged
merged 3 commits into from
Oct 28, 2024
Merged

fix: remove wrapper.mjs #822

merged 3 commits into from
Oct 28, 2024

Conversation

broofa
Copy link
Member

@broofa broofa commented Oct 28, 2024

@ctavan @TrySound : Do we still need the wrapper.mjs file in light of the uuid@v11 refactoring / changes to node since #423 went in?

#820 Isn't an issue with uuid per se, but it does speak to the additional code-complexity that comes with the wrapper approach. It'd be nice to get rid of it.

I've scanned #423 but my grasp of the issues there is a bit dated. I need to refresh my memory. In the meantime I'm unsure how relevant this still is.

@broofa
Copy link
Member Author

broofa commented Oct 28, 2024

Looking into this further I'm 99% sure we can kill wrapper.mjs. It was intended as a way to bridge node's experimental ESM support to the CJS code base, which was the preferred implementation at the time. That's not really a relevant concern any longer... not for me, at least. 😁 In fact, in uuid@10 the file wrapper.mjs was importing (dist/index.js) was CJS, not ESM, but it now points to dist/esm/index.js which is, at best, a benign bug that makes wrapper.mjs synonomous with dist/esm/index.js in uuid@v11.0.1 currently.

So... in the interests of mitigating the # of users impacted by this change I'm going to go ahead and push a new patch-release. For anyone impacted by this... uh... "I'm sorry"... and please comment here or open a new issue where we can discuss how / why we need to continue supporting your use case.

@broofa broofa changed the title chore: remove wrapper.mjs fix: remove wrapper.mjs Oct 28, 2024
@broofa broofa merged commit 6683ad3 into main Oct 28, 2024
10 checks passed
@broofa broofa deleted the fix_820 branch October 28, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant