-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Move UmaskGuard in uucore and use it for mkdir, mkfifo & mknod #10310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
40ce322 to
c20327c
Compare
|
GNU testsuite comparison: |
| } | ||
|
|
||
| #[test] | ||
| #[cfg(unix)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is failing because the coverage tests use -Cpanic=abort so they don't have catch_unwind
You can add:
#[cfg(panic = "unwind")]
|
I think we have to be careful adding umask integration tests when its running multi-threaded because the UMaskGuard affects the process, when stress testing it the tests were flaky. Maybe adding a Mutex in the unit tests? Might be good to add a comment in the helper function: |
|
GNU testsuite comparison: |
followup of #10036