Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "mv fails transfers between dirs" #1305

Merged
merged 6 commits into from
Apr 3, 2019
Merged

fix "mv fails transfers between dirs" #1305

merged 6 commits into from
Apr 3, 2019

Conversation

rivy
Copy link
Member

@rivy rivy commented Oct 18, 2018

  • includes test which demonstrates the problem

Note that this is on top of the improved testing introduced in PR#1281.

Copy link
Collaborator

@Arcterus Arcterus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also rebase your PRs? There's a lot of extra commits from the PR I just merged mixed in.

src/mv/mv.rs Outdated Show resolved Hide resolved
src/mv/mv.rs Outdated Show resolved Hide resolved
@rivy
Copy link
Member Author

rivy commented Feb 7, 2019

I'll be happy to rebase all my PRs (they had to be based upon the initial PR in order to use the CI testing). It'll take me a just a little bit of time.

@rivy
Copy link
Member Author

rivy commented Feb 7, 2019

@Arcterus , I rebased all of the basic PRs (#1304, #1305, #1315, #1316, #1317, #1319) and did some quick prelimary testing which looks fine (CI is still pending).

@rivy
Copy link
Member Author

rivy commented Feb 27, 2019

@Arcterus ,

I believe this PR should be good to merge.
Plus, besides this, will you look at the other PRs mentioned (#1304, #1305, #1315, #1316, #1317, #1319)?
I think they are all relatively straight-forward fixes.
And, I don't want them to get stale and have to all be rebased again.
I'm happy to make changes, if needed.

@rivy
Copy link
Member Author

rivy commented Mar 29, 2019

@Arcterus , @cnd , I'm checking back in on these PRs (#1304, #1305, #1315, #1316, #1317, #1319). Are there any issues that need attention or are these mergeable?

@Arcterus
Copy link
Collaborator

Arcterus commented Apr 3, 2019

Sorry it's taken so long, I'm gonna go through these.

@Arcterus Arcterus merged commit 8d15f36 into uutils:master Apr 3, 2019
@rivy rivy deleted the fix.mv branch December 8, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants