-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rm: add verbose output and trim multiple slashes #1988
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f0eb210
rm: add verbose output and trim multiple slashes
marvin-bitterlich a635b23
rm: fix the test for windows using \\
marvin-bitterlich d90f5c3
rm: test format
marvin-bitterlich 63d0a6e
rm: rename unify to normalize as that is the name used elsewhere
marvin-bitterlich f1e2e7b
rm: use separator constant
marvin-bitterlich c2405d8
Merge remote-tracking branch 'uutils/master' into rm-1829
marvin-bitterlich 3e38131
rm: move `normalize_path` to uucore and add tests
marvin-bitterlich 84cc40b
rm: run format
marvin-bitterlich be74e81
rm: support windows
marvin-bitterlich 973229c
rm: more char magic
marvin-bitterlich 8b7b09b
rm: add some extra test cases to bump coverage
marvin-bitterlich 433cef6
rm: cover windows network shares
marvin-bitterlich a9de357
rm: run fmt
marvin-bitterlich 7c93f84
Merge branch 'master' into rm-1829
marvin-bitterlich daffd7a
Merge branch 'master' into rm-1829
marvin-bitterlich 77f3b08
rm: remove trailing whitespace
marvin-bitterlich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -150,7 +150,7 @@ jobs: | |
uses: actions-rs/cargo@v1 | ||
with: | ||
command: test | ||
args: --features "feat_os_unix" | ||
args: --features "feat_os_unix" -p uucore -p coreutils | ||
env: | ||
RUSTFLAGS: '-Awarnings' | ||
|
||
|
@@ -536,6 +536,17 @@ jobs: | |
CARGO_UTILITY_LIST_OPTIONS="$(for u in ${UTILITY_LIST}; do echo "-puu_${u}"; done;)" | ||
echo set-output name=UTILITY_LIST::${UTILITY_LIST} | ||
echo ::set-output name=CARGO_UTILITY_LIST_OPTIONS::${CARGO_UTILITY_LIST_OPTIONS} | ||
- name: Test uucore | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto |
||
uses: actions-rs/cargo@v1 | ||
with: | ||
command: test | ||
args: ${{ steps.vars.outputs.CARGO_FEATURES_OPTION }} --no-fail-fast -p uucore | ||
env: | ||
CARGO_INCREMENTAL: '0' | ||
RUSTC_WRAPPER: '' | ||
RUSTFLAGS: '-Zprofile -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort' | ||
RUSTDOCFLAGS: '-Cpanic=abort' | ||
# RUSTUP_TOOLCHAIN: ${{ steps.vars.outputs.TOOLCHAIN }} | ||
- name: Test | ||
uses: actions-rs/cargo@v1 | ||
with: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -226,6 +226,11 @@ If you would prefer to test a select few utilities: | |
$ cargo test --features "chmod mv tail" --no-default-features | ||
``` | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
If you also want to test the core utilities: | ||
```bash | ||
$ cargo test -p uucore -p coreutils | ||
``` | ||
|
||
To debug: | ||
```bash | ||
$ gdb --args target/debug/coreutils ls | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this
please create a separate PR for this with the rational
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created #2030 which now blocks this pr :)