Sort: Implement stable sort, ignore non-printing, month sort dedup, auto parallel sort through rayon, zero terminated sort, check silent #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
…on't know about how general numeric is implemented. No way to do a random test?
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
Co-authored-by: Sylvestre Ledru <sledru@mozilla.com>
…ndom shuffling, and add back my previous unit tests
…he same as resulting
This reverts commit 5d8a98c.
|
I'm supposing you're waiting on -k and -T to resolve conflicts, but I just discovered an issue with some of my tests. I should resolve before you commit. Thanks. |
sylvestre
reviewed
Apr 8, 2021
| Arg::with_name(OPT_CHECK_SILENT) | ||
| .short("C") | ||
| .long(OPT_CHECK_SILENT) | ||
| .help("exit successfully if the given file is already sorted, and exit with status 1 otherwise. "), |
There was a problem hiding this comment.
please remove the trailing space (new PR is fine)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd ask the reviewer squash these many, many commits, if they can, because I can't figure it out!
Implemented GNU’s version of stable sort (last resort comparison), ignore non-printing, month sort dedup, auto parallel sort through rayon, zero terminated sort, check silent. Specifically, last resort comparison fixes all sorts of ordering issues when given mixed type inputs.
Created a general numeric compare option. Right now, numeric compare is mostly an emulation mode for what GNU accomplishes through strnumcmp/strncmp. Thus GNU's numeric is on CPU much less. If anyone would like to help implement that, it would be appreciated.
Switched to FNV hash for random shuffle because it has better small input characteristics. See: https://github.com/Gankra/hash-rs
Removed my tests within sort.rs, but created lots of new tests in test_sort.rs.
Fixed month sort - panic on unwrap for longer matches, ie JUNNNN=JUN, and lots of other weird bugs.
AFAIK this is most of the major functionality of GNU sort except key and separator sort which is what I will try next.