Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD: add CARGO_TERM_COLOR env var for colors in CI output #4165

Closed
wants to merge 1 commit into from

Conversation

tertsdiepraam
Copy link
Member

@tertsdiepraam tertsdiepraam commented Nov 19, 2022

This hopefully makes the CI output a bit prettier :)

EDIT: Seems to have worked mostly. I want to figure out how to also enable color in the tests though.

@tertsdiepraam
Copy link
Member Author

Great, apparently it's due to an issue open since 2015 :)

rust-lang/cargo#1983

@tertsdiepraam tertsdiepraam force-pushed the cargo-colors-in-ci branch 3 times, most recently from 49fcde1 to c10d102 Compare November 19, 2022 20:19
@uutils uutils deleted a comment from github-actions bot Nov 19, 2022
@tertsdiepraam
Copy link
Member Author

tertsdiepraam commented Nov 19, 2022

Well, I can't get it to work in cargo test. I removed those changes and leave that for later.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/timeout. tests/misc/timeout is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

@sylvestre
Copy link
Contributor

While I log colors, i am not a big fan in the CI. it is clobbering the raw logs:
https://pipelines.actions.githubusercontent.com/serviceHosts/91055393-6e6f-4662-ba97-3acee74a8c7c/_apis/pipelines/1/runs/20716/signedlogcontent/6?urlExpires=2023-01-27T20%3A12%3A46.9850910Z&urlSigningMethod=HMACV1&urlSignature=gbO%2Be6ji8njlwtpV7mcX87sxHkEn2Ak7VdOYlUatM1o%3D


2022-12-06T07:55:24.0549810Z �[0m�[0m�[1m�[32m   Compiling�[0m proc-macro-error v1.0.4
2022-12-06T07:55:25.6700050Z �[0m�[0m�[1m�[32m   Compiling�[0m num-bigint v0.4.3
2022-12-06T07:55:25.7502200Z �[0m�[0m�[1m�[32m   Compiling�[0m lock_api v0.4.9
2022-12-06T07:55:26.2127390Z �[0m�[0m�[1m�[32m   Compiling�[0m filetime v0.2.18

@tertsdiepraam
Copy link
Member Author

Sure, I don't look at the raw logs much, but if you think it's important we can close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants