Default environment variables for tests #4593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now run each command with TZ=UTC and LC_ALL=C to ensure consistent behavior independent from external timezone and locale settings. These can still be overridden with other values if necessary.
Use a specific time to check whether any DST problems arise. The test is also ignored, because this functionality seems to be broken at the moment. Still, this is an improvement, because it is more reliable and does not need to obtain a local offset, which might lead to a panic in the time library.
|
I think the DST test I changed in the second commit was actually broken since #3319? Unless I'm making some mistake. GNU is failing for the timezone and time that I give it but uutils doesn't. |
tertsdiepraam
changed the title
|
touch: move from time to chrono Maybe in a separate PR ? |
tertsdiepraam
force-pushed
the
default-env-for-tests
branch
from
e40be52 to
2e104e4
Compare
|
Yeah that's probably better. Edit: Done :) |
tertsdiepraam
force-pushed
the
default-env-for-tests
branch
from
2e104e4 to
c8ece3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4586 and hopefully also #4253 but I won't let it close the latter automatically.