hashsum: implement the ignore-missing option #6230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested by gnu/tests/cksum/md5sum.pl
BenWiederhake
requested changes
Apr 15, 2024
Collaborator
BenWiederhake
left a comment
BenWiederhake
left a comment
There was a problem hiding this comment.
The implementation is straight-forward, and the test checks the implementation. But I think this case was missed?
$ ../gnu/src/md5sum --ignore-missing LICENSE
../gnu/src/md5sum: the --ignore-missing option is meaningful only when verifying checksums
Try '../gnu/src/md5sum --help' for more information.
[$? = 1]
$ cargo run md5sum --ignore-missing LICENSE
e74349878141b240070458d414ab3b64 LICENSE
$
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by gnu/tests/cksum/md5sum.pl