hashsum: improve the error management to match GNU #6252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
cakebaker
reviewed
Apr 20, 2024
cakebaker
reviewed
Apr 20, 2024
cakebaker
reviewed
Apr 20, 2024
cakebaker
reviewed
Apr 20, 2024
cakebaker
reviewed
Apr 20, 2024
|
GNU testsuite comparison: |
BenWiederhake
approved these changes
Apr 20, 2024
Collaborator
BenWiederhake
left a comment
BenWiederhake
left a comment
There was a problem hiding this comment.
Looks good. Two nits:
- I guess the seq commits should have been part of a separate PR, but whatever, let's merge it.
- The code handles singular/plural forms separately, but the tests don't check for it. Shouldn't that be tested?
| .fails() | ||
| .stdout_is("sha1sum: testf: No such file or directory\ntestf: FAILED open or read\n") | ||
| .stderr_is("sha1sum: warning: 1 listed file could not be read\n"); | ||
| .stderr_is("sha1sum: WARNING: 1 listed file could not be read\n"); |
Collaborator
There was a problem hiding this comment.
The code potentially outputs a plural form. Is that part of our guarantee to the user?
- If yes, then it should be part of the tests.
- If no, then the code can be deleted/simplified.
Contributor
Author
There was a problem hiding this comment.
i will do it in a different PR, I have other changes pending
Should make tests/cksum/md5sum.pl and tests/cksum/sha1sum.pl pass
Contributor
Author
|
the seq change was a mistake, I removed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make tests/cksum/md5sum.pl pass