-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
seq: add f128 code paths #6630
base: main
Are you sure you want to change the base?
seq: add f128 code paths #6630
Conversation
Clean up the code in uumain, making it more readable and easier to modify to use f128s.
Add a positive (accepts `f128`) and a negative (rejects non `f128`) test.
GNU testsuite comparison:
|
feature gated because it requires libquadmath
The main features this needs to work on nightly are I tried implementing them by converting to/from I'll keep this as a draft and keep an eye on the If anyone in the future wants to give this a shot, then check the following links:
|
@jalil-salame it is still marked as draft, are you still working on it? thanks |
It is blocked by these issues, I left it open so that contributors could see this before starting an attempt, if you feel it should be closed/reattempted, feel free to do so |
refactors
uumain
adds regression test for
seq 4e4000003 4e4000003
is causing an infinite loop #6182 (commented out until implementation is done)preliminary implementation of the f128 code path (feature gated)
I'm having issues with
libquadmath.so.0
: it loads fine when I run the binary directly (target/debug/coreutils seq ...
), but fails when I run the tests (cargo test
/cargo nextest run
). It might be a weird NixOS issue though.I'll try using the nightly
f128
code tomorrow to verify the tests pass.